I expect CMD+N to open a new Window, but it doesnt!
Oh actually it works. It doesnt' work from this documenth:
Solution
PR #1417 is open for review, not merged.
Summary: Cmd/Ctrl+N now falls back to a new welcome-page window when a window already shows the sidebar space home. Otherwise it opens the space home, preserving one window per document.
Root cause: getFocusedWindowNewWindowRoute targets the space home, while createAppWindow focuses an existing window for an already-open document. Together these made New Window merely refocus the existing home window.
Verification reported by T3: On unmodified code, three new regression tests failed on two runs (3 failed, 19 passed). With the fix, app-window-state tests passed 22/22; related account-selection and app-menu tests passed 24/24. Desktop typecheck and Prettier on both changed files passed. Real Electron/macOS interaction is unverified: no X display, and Playwright Chromium could not start because libnspr4.so was missing with no sudo available. Local agent-ci did not run because Docker was unavailable.
Product decision requiring review: The coding agent chose the welcome-page fallback; the issue does not specify the destination and Horacio has not confirmed it. Please confirm that choice and test Cmd+N on the space home in the macOS app.
Before / After
Before: Regression tests reproduced the existing home window being refocused instead of opening a new window. No screenshot or recording captured.
After: The same regression tests pass with the welcome-page fallback. No screenshot or recording captured. Both evidence and artifacts arrays were empty, so no visual pair is available to publish.
Do you like what you are reading? Subscribe to receive updates.
Unsubscribe anytime